- Notifications
You must be signed in to change notification settings - Fork3.9k
Fix minor grammatical errors#3410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Fix minor grammatical errors#3410
Uh oh!
There was an error while loading.Please reload this page.
Conversation
CLAassistant commentedMar 19, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
| @@ -5,7 +5,7 @@ There are two kinds of object properties. | |||
| The first kind is *data properties*. We already know how to work with them. All properties that we've been using until now were data properties. | |||
| The second type of property is something new. It's an *accessor property*. They are essentially functions that execute on getting and setting a value, but look like regular properties to an external code. | |||
| The second type of property is something new. It's an *accessor property*. They are essentially functions that execute on getting and setting a value but look like regular properties to an external code. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
disagree, clearer with comma
| @@ -241,4 +241,4 @@ alert( john.birthday ); // birthday is available | |||
| alert( john.age ); // ...as well as the age | |||
| ``` | |||
| Now the old code works too and we've got a nice additional property. | |||
| Now the old code works, too, and we've got a nice additional property. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
maybe:
Now the old code works too, and we've got a nice additional property.
| - **`get`** -- a function without arguments, that works when a property is read, | ||
| - **`set`** -- a function with one argument, that is called when the property is set, | ||
| - **`get`** -- a function without arguments that works when a property is read, | ||
| - **`set`** -- a function with one argument that is called when the property is set, | ||
| - **`enumerable`** -- same as for data properties, | ||
| - **`configurable`** -- same as for data properties. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
might suggest dropping punctuation at end of bullets as well:
get-- a function without arguments that works when a property is readset-- a function with one argument that is called when the property is setenumerable-- same as for data propertiesconfigurable-- same as for data properties
javascript-translate-bot commentedAug 24, 2024
Please make the requested changes. After it, add a comment "/done". |
/done |
Uh oh!
There was an error while loading.Please reload this page.