- Notifications
You must be signed in to change notification settings - Fork3.9k
Promises basics#3285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Promises basics#3285
Uh oh!
There was an error while loading.Please reload this page.
Conversation
shallow-beach left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
a few comments
| The call `.finally(f)` is similar to `.then(f, f)` in the sense that `f` runs always, when the promise is settled: be it resolve or reject. | ||
| The idea of `finally` is to set up a handler for performing cleanup/finalizing after the previous operations are complete. | ||
| E.g. stopping loading indicators, closing no longer needed connections, etc. | ||
| Think of it as a party finisher. No matterwas a party good or bad, how many friends were in it, we still need (or at least should) do a cleanup after it. | ||
| Think of it as a party finisher. No matterif a party was good or bad, how many friends were in it, we still need (or at least should) do a cleanup after it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
i prefer the solution at#3390
| @@ -214,15 +214,15 @@ The call `.catch(f)` is a complete analog of `.then(null, f)`, it's just a short | |||
| ## Cleanup: finally | |||
| Just like there's a `finally` clause in a regular `try {...} catch {...}`, there's `finally` in promises. | |||
| Just like there's a `finally` clause in a regular `try {...} catch {...}`, there'sa`finally` in promises also. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
maybe:
Just like there's a
finallyclause in a regulartry {...} catch {...}, there's afinallyfor promise chains.
| @@ -291,7 +291,7 @@ Sometimes, it might be that a promise is already settled when we add a handler t | |||
| In such case, these handlers just run immediately: | |||
| ```js run | |||
| // the promise becomesresolved immediately upon creation | |||
| // the promise becomessettled immediately upon creation | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
disagree, 'resolve' goes well with use ofresolve in the article's examples. Maybe 'fulfilled' if trying to use ECMA term.
Lines 294 and 327 refer to line 84:
Lines 227 and 225 just have some potentially good improvements for readability.