Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Address some possible issues in 1.2.11#2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iliakan merged 1 commit intojavascript-tutorial:masterfromvsemozhetbyt:1.2.11
Sep 23, 2020
Merged

Address some possible issues in 1.2.11#2134

iliakan merged 1 commit intojavascript-tutorial:masterfromvsemozhetbyt:1.2.11
Sep 23, 2020

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbytvsemozhetbyt commentedSep 20, 2020
edited
Loading

  1. Fix some typos.
  2. Replace== with=== in a task when it is appropriate to make reader accustomed to good practice.
  3. Fix some metrics in SVG that caused ugly effect in dark browser mode.

@iliakan
Copy link
Member

What did you fix in SVGs? We use Sketch as the editor, and SVGs are auto-exported, so I'd better fix it there.

@vsemozhetbyt
Copy link
ContributorAuthor

I will be able to tell a bit later. Some text was out of colored boxes in dark mode, so I may decrease font size and change coordinates.

@vsemozhetbyt
Copy link
ContributorAuthor

vsemozhetbyt commentedSep 22, 2020
edited
Loading

Here is the screenshot of current svg from my phone, so I think I've changed the ECMASript block. And maybe l've moved "You don't know...' a bit to the left side, I am not sure now, sorry.

screenshot

Screenshot_2020-09-22-15-09-15-020_com android chrome

@iliakan
Copy link
Member

It seems, you changed another svg: ifelse_task.svg

@vsemozhetbyt
Copy link
ContributorAuthor

vsemozhetbyt commentedSep 22, 2020
edited
Loading

Sorry, wrong PR.

Here, "TheMaster" may be the issue.

screenshot

Screenshot_2020-09-22-15-31-49-455_com android chrome

@vsemozhetbyt
Copy link
ContributorAuthor

Sorry for the mess, trying to answer from the subway.

@vsemozhetbyt
Copy link
ContributorAuthor

vsemozhetbyt commentedSep 22, 2020
edited
Loading

Should I exclude svg from this PR?
(Sorry, it seems I have not changed1-js/02-first-steps/10-ifelse/2-check-standard/ifelse_task2.svg in the previous PR, so maybe it also needs your attention because of "ECMASript" block issue).

@iliakan
Copy link
Member

Please change it in the sketch instead

1 similar comment
@iliakan
Copy link
Member

Please change it in the sketch instead

@iliakan
Copy link
Member

iliakan commentedSep 22, 2020
edited
Loading

Or maybe better just don’t touch svgs at all. Anyway will need a total revision of all svgs for the dark mode

@vsemozhetbyt
Copy link
ContributorAuthor

SVG excluded.

@iliakan
Copy link
Member

Thanks!

@iliakaniliakan merged commit2aad40b intojavascript-tutorial:masterSep 23, 2020
@vsemozhetbytvsemozhetbyt deleted the 1.2.11 branchSeptember 23, 2020 16:12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@vsemozhetbyt@iliakan

[8]ページ先頭

©2009-2025 Movatter.jp