Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3
Coding Style#97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Coding Style#97
Changes fromall commits
Commits
Show all changes
6 commits Select commitHold shift + click to select a range
e58522f
1.3.2
otmon762adf780
Update 1-js/03-code-quality/02-coding-style/article.md
otmon76ddeb82e
Update 1-js/03-code-quality/02-coding-style/article.md
otmon76747ceda
Update 1-js/03-code-quality/02-coding-style/article.md
otmon76f7ed26a
Update 1-js/03-code-quality/02-coding-style/article.md
otmon76220acc7
Update 1-js/03-code-quality/02-coding-style/article.md
otmon76File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
46 changes: 23 additions & 23 deletions1-js/03-code-quality/02-coding-style/1-style-errors/solution.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,48 +1,48 @@ | ||
Měli byste si všimnout následujícího: | ||
```js no-beautify | ||
functionmocnina(x,n) // <-chybí mezera mezi argumenty | ||
{ // <-levá složená závorka na zvláštním řádku | ||
letvýsledek=1; // <-chybějí mezery před a za = | ||
for(let i=0;i<n;i++) {výsledek*=x;} // <-chybějí mezery | ||
//obsah{ ... }by měl být na novém řádku | ||
returnvýsledek; | ||
} | ||
let x=prompt("x?",''), n=prompt("n?",'') // <--technicky je to možné, | ||
//ale lepší je to rozdělit na 2 řádky, navíc tam chybějí mezery a ; | ||
if (n<=0) // <-chybějí mezery uvnitř (n <= 0) a nad ním by měl být prázdný řádek | ||
{ // <-levá složená závorka na zvláštním řádku | ||
//níže -dlouhé řádky by měly být rozděleny na více řádků pro lepší čitelnost | ||
alert(`${n}-tá mocnina není podporována, zadejte prosím celé číslo větší než nula`); | ||
} | ||
else // <-toto může být na jediném řádku: "} else {" | ||
{ | ||
alert(mocnina(x,n)) //chybějí mezery a ; | ||
} | ||
``` | ||
Opravená varianta: | ||
```js | ||
functionmocnina(x, n) { | ||
letvýsledek = 1; | ||
for (let i = 0; i < n; i++) { | ||
výsledek *= x; | ||
} | ||
returnvýsledek; | ||
} | ||
let x = prompt("x?", ""); | ||
let n = prompt("n?", ""); | ||
if (n <= 0) { | ||
alert(`${n}-tá mocnina není podporována, | ||
zadejte prosím celé číslo větší než nula`); | ||
} else { | ||
alert(mocnina(x, n) ); | ||
} | ||
``` |
18 changes: 9 additions & 9 deletions1-js/03-code-quality/02-coding-style/1-style-errors/task.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.