Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Code editors, Developer console#5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
danipoma merged 8 commits intojavascript-tutorial:masterfromotmon76:master
Oct 25, 2020

Conversation

@otmon76
Copy link
Contributor

No description provided.

@javascript-translate-botjavascript-translate-bot added the review neededReview needed, please approve or request changes labelOct 24, 2020
@CLAassistant
Copy link

CLAassistant commentedOct 24, 2020•
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@danipomadanipoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just a minor thing as well to mention.

I believe that best practice should be to create new branch and add those changes there just in case so you can keep master branch in sync and promote changes in temporary branches.

Don't take my word for it though, this is my second day using git.

@javascript-translate-botjavascript-translate-bot removed the review neededReview needed, please approve or request changes labelOct 24, 2020
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-botjavascript-translate-bot added the changes requestedWaiting for changes and /done from PR author labelOct 24, 2020
@danipomadanipoma changed the titleUpdate article.mdCode editors, Developer consoleOct 24, 2020
@otmon76
Copy link
ContributorAuthor

/done

@javascript-translate-botjavascript-translate-bot added review neededReview needed, please approve or request changes and removed changes requestedWaiting for changes and /done from PR author labelsOct 25, 2020
@javascript-translate-botjavascript-translate-bot added needs +1One more review needed and removed review neededReview needed, please approve or request changes labelsOct 25, 2020
@danipomadanipoma merged commit19ff647 intojavascript-tutorial:masterOct 25, 2020
@danipomadanipoma removed the needs +1One more review needed labelOct 25, 2020
@danipomadanipoma mentioned this pull requestOct 25, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@danipomadanipomadanipoma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@otmon76@CLAassistant@javascript-translate-bot@danipoma
[8]ページ先頭
©2009-2025 Movatter.jp