- Notifications
You must be signed in to change notification settings - Fork37
Usegulp-sourcemaps
for source maps#18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Wain-PC merged 2 commits intojavascript-obfuscator:masterfromDRSDavidSoft:sourcemaps-fixApr 19, 2019
Merged
Usegulp-sourcemaps
for source maps#18
Wain-PC merged 2 commits intojavascript-obfuscator:masterfromDRSDavidSoft:sourcemaps-fixApr 19, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Thank you, looks good to me! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
This PR addresses a couple of issues with source maps:
gulp-header
from prepending to the source maps as well as the codeBecause ofjavascript-obfuscator/javascript-obfuscator#276, we can now usegulp-sourcemaps instead of throwing the source map to the stream! 😄
Backwards compatibility
As before, if
gulp-sourcemaps
is not used and obfuscator'ssourceMap option is set totrue, a.map file will be thrown to Gulp stream.NOTE: The old method is not recommended for new projects, for the following reasons:
Any gulp plugin that is chained after gulp-javascript-obfuscator (e.g.
gulp-header
to prepend a banner to the output file) will be applied onboth the obfuscated.js file and its.map file.You will not be able to chain any other plugins to the task without loosing its own sourcemap file.