- Notifications
You must be signed in to change notification settings - Fork1.2k
Add structure support for Java 22, 23 and 24 (no features)#4769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
(cherry picked from commit c8e0872b26cdc6a61d6d520defe91c06115a252f)
| * This validator validates according to Java21 syntax rules. | ||
| * This validator validates according to Java24 syntax rules. | ||
| * | ||
| * @see <a href="https://openjdk.java.net/projects/jdk/21/">https://openjdk.java.net/projects/jdk/21/</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
correct link
| * This validator validates according to Java21 syntax rules. | ||
| * This validator validates according to Java23 syntax rules. | ||
| * | ||
| * @see <a href="https://openjdk.java.net/projects/jdk/21/">https://openjdk.java.net/projects/jdk/21/</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
correct link
| * This validator validates according to Java21 syntax rules. | ||
| * This validator validates according to Java22 syntax rules. | ||
| * | ||
| * @see <a href="https://openjdk.java.net/projects/jdk/21/">https://openjdk.java.net/projects/jdk/21/</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
correct link
| * This validator validates according to Java21 syntax rules. | ||
| * This validator validates according to Java23 syntax rules. | ||
| * | ||
| * @see <a href="https://openjdk.java.net/projects/jdk/21/">https://openjdk.java.net/projects/jdk/21/</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
correct link
| /** | ||
| * Java 24 | ||
| */ | ||
| JAVA_24(newJava24Validator(),newJava24PostProcessor()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
could we prepare for JAVA_25 directly?
| JAVA_24(newJava24Validator(),newJava24PostProcessor()); | ||
| /** | ||
| * Does no post processing or validation. Only for people wanting the fastest parsing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
maybe also time to update
public static LanguageLevel POPULAR = JAVA_11; -> 17?
public static LanguageLevel CURRENT = JAVA_18; -> 21=
public static LanguageLevel BLEEDING_EDGE = JAVA_21; -> 24?
Thank you for this proposition, but this PR will not be merged in this state because JP does not support all the features of the various java versions. If this PR had been subdivided into several PRs (one per version of java) they would have been easier to integrate as soon as the different features specific to each version had been developed. |
Fixes#4699