NotificationsYou must be signed in to change notification settings
Fork633
Star8.1k

Fix virtual threads enabled bug on native images for graalVM#2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

tipsy merged 4 commits intojavalin:masterfromacolita:virtual-thread-builder

Apr 27, 2025

Merged

Fix virtual threads enabled bug on native images for graalVM#2361

tipsy merged 4 commits intojavalin:masterfromacolita:virtual-thread-builder

Apr 27, 2025

Conversation

Copy link

Contributor

OlavoAcolita commentedJan 24, 2025

Relevant issue:#2192

Fix proposed on issue.

Created a new class (VirtualThreadBuilder) for fixing virtual threads enabled bug on native images for graalVM.

VirtualThreadBuilder created for fixing virtual threads enabled bug o…

e524edb

…n native images on graalVM

OlavoAcolita closed this

Feb 11, 2025

OlavoAcolita reopened this

Feb 11, 2025

Copy link

codecovbot commentedFeb 13, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is0% with11 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base(00ceaff) to head(ec80cfe).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...n/src/main/java/io/javalin/util/ConcurrencyUtil.kt	0.00%	11 Missing⚠️

Additional details and impacted files

@@          Coverage Diff           @@##           master   #2361   +/-   ##======================================  Coverage    0.00%   0.00%           ======================================  Files         148     148             Lines        4498    4492    -6       Branches      513     513           ======================================+ Misses       4498    4492    -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Member

tipsy commentedMar 2, 2025

Thanks@OlavoAcolita ! I see Codecov is complaining a bit, I'm not sure how well tested the existing implementation was 🤔

I will try to have a look before next weekend.@dzikoysk I saw you in the emoji-section of the issue, did you check this out yet?

dzikoysk reviewed

Mar 2, 2025

View reviewed changes

javalin/src/main/java/io/javalin/util/ConcurrencyUtil.kt Outdated

		}

		openclassReflectiveVirtualThreadBuilder {
		classVirtualThreadBuilder {

Copy link

Member

dzikoyskMar 2, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You can convert this class into the object class (singleton) and get rid of the companion object at all. It'll make more sense, also considering that we're not creating a new instance of it.

+ should fix coverage