- Notifications
You must be signed in to change notification settings - Fork136
Support for templates for JNLPBundler, and support for bundler parameters 'title' and 'description'#332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ters 'title' and 'description'
…ters 'title' and 'description'
Indeed, the string-converter is missing. I think I haven't seen this the last time you proposed some change to this area. To be honest I'm not sure how to deal with this, as starting with JDK11 the support for Java Web Start/JNLP is getting dropped (this is public on the dev-news). How do you think about this@francesco-kriegel ? |
Hi Sorry for the late reply. However, my answer is rather short: if support for Java Web Start is really about to be dropped soon, then it would probably not make too much sense to integrate this pull request. At least this holds true when always developing against the latest JDK. If one decides to stick to, say, JDK 8 for a while, since one gets dizzy due to the rapid version increments, then it could be beneficial for those developers to integrate this. It is up to you to decide! Ciao |
Uh oh!
There was an error while loading.Please reload this page.
This is the third attempt to get my pull request accepted and integrated, after#94 and#122 were declined, and a feature proposed in#122 was later integrated in#255.
The commit I am asking you to integrate allows for three further bundler parameters:
jnlpTemplates
-- a list of HTML files to be processed as templates byJNLPBundler
title
-- a title to be used by any supporting bundler, and which defaults to${project.name}
description
-- a description to be used by any supporting bundler, and which defaults to${project.description}
Although@FibreFoX has integrated the option to specify
<bundleArguments>
andjnlp.templates
is aStandardBundlerParam
, cf.JNLPBundler
, such a list of files cannot be parsed from thepom.xml
, since a String converter is missing, seeJNLPBundler
. My solution to this works as follows.jnlpTemplates
is defined in theNativeMojo
.<jnlpTemplate>
entries (within<jnlpTemplates>
) pointing to files to be used as templates by theJNLPBundler
.NativeMojo
for the bundlerjnlp
, then thisList<File>
is converted into aMap<File,File>
, see Lines 757-765, and theMap<File,File>
is then added toparamsToBundleWith
with keyjnlp.templates
.NativeMojo
, the processed HTML files can be found intarget/jfx/native
.In case one needs further control on where to output and store the processed HTML files, one could extend the field
jnlpTemplates
to allow for the declaration of pairs of input and output files. Currently, it is only a list of input files the names of which are used as names of the output files undertarget/jfx/native
.