- Notifications
You must be signed in to change notification settings - Fork1.6k
JASPIC ServerAuthModule and ServerAuthContext spec compliance fixes#375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
stoty wants to merge1 commit intojavaee-samples:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This contains two sets of fixes:- The SAMs no longer return SUCCESS with emtpy principals for mandatoryauthentication- The ServerAuthContext sets up two SAM module instances to satisfy thespec requirement that the mandatory flag can be accessed from therequestPolicyThe first fix is important, as currently the tests fail to return properhttp status codes for unathenticated protected resources on multiple appservers.The second fix is just for complying with the letter of the spec, as therequestPolicy is not actually used in any of the current tests.
I've glanced over the PR and it looks good at first sight, but I'm very busy now with JSF 2.3 (final day before it closes). But haven't forgotten about this PR ;) Will look at it soon in more detail. Thanks for now! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains two sets of fixes:
authentication
spec requirement that the mandatory flag can be accessed from the
requestPolicy
The first fix is important, as currently the tests fail to return proper
http status codes for unathenticated protected resources on multiple app
servers.
The second fix is just for complying with the letter of the spec, as the
requestPolicy is not actually used in any of the current tests.