Commitbd20467

zhourenjian@gmail.com

committed

Generate key use Math.random correctly or precisely random

1 parent24cd307 commitbd20467Copy full SHA for bd20467

File tree

-6

lines changed

sources/net.sf.j2s.ajax/ajaxpipe/net/sf/j2s/ajax
- CompoundPipeRunnable.java
- SimplePipeHelper.java

-6

lines changed

Lines changed: 4 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,13 +3,12 @@`
`3`	`3`	`publicclassCompoundPipeRunnableextendsSimplePipeRunnable {`
`4`	`4`
`5`	`5`	`privatestaticStringnextSessionKey() {`
`6`		`-StringhexStr ="0123456789abcdef";`
`7`		`-Stringkey ="";`
	`6`	`+StringBufferkeyBuffer =newStringBuffer(4);`
`8`	`7`	`for (inti =0;i <4;i++) {`
`9`		`-inthex = (int)Math.round(15 *Math.random());`
`10`		`-key +="" +hexStr.charAt(hex);`
	`8`	`+inthex = (int)Math.floor(Math.random() *16);`
	`9`	`+keyBuffer.append((char) (hex <10 ? ('0' +hex) : ('a' +hex -10)));`
`11`	`10`	`}`
`12`		`-returnkey;`
	`11`	`+returnkeyBuffer.toString();`
`13`	`12`	`}`
`14`	`13`
`15`	`14`	`CompoundPipeSession[]pipes;`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ synchronized static String registerPipe(SimplePipeRunnable pipe) {`
`120`	`120`	`staticStringnextPipeKey() {`
`121`	`121`	`StringBufferbuf =newStringBuffer(SimplePipeRequest.PIPE_KEY_LENGTH);`
`122`	`122`	`for (inti =0;i <SimplePipeRequest.PIPE_KEY_LENGTH;i++) {`
`123`		`-intr = (int)Math.round((float)Math.random() *61);// 0..61, total 62 numbers`
	`123`	`+intr = (int)Math.floor(Math.random() *62);// 0..61, total 62 numbers`
`124`	`124`	`if (r <10) {`
`125`	`125`	`buf.append((char) (r +'0'));`
`126`	`126`	`}elseif (r <10 +26) {`

Comments

(0)