Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork209
Proposal/issue 44#45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
It appears that the configuration reportLinesUnchanged has no effectwhen showInlineDiffs is true. That is '<' and '>' characters areconverted to HTML entities regardless.
rosta commentedJul 31, 2019
I'm beginning to think that this might not be the best solution. A better way forward might be to split the diffing and the formatting into two phases and let the client code call appropriate formatting routines directly. However that would mean that differences are calculated twice. Once when differences are found and classified, and once when the diff marker tags are interpolated into the formatted text. Hmmm... |
wumpz commentedJul 31, 2019
The diffing and formatting are done in two phases, IMHO. How do you want to split it? |
rosta commentedAug 1, 2019
Yes, I hear what you say. I don't mean to dish what has already been doneand works. It's just that I haven't yet found how to get the output I need. Worse, I don't even know what that is exactly :-( I'll be looking at that this week. Please don't do anything with this PR for the moment until I can update it. |
wumpz commentedAug 1, 2019
Would it be an improvement, if you don't use the default line normalizer? |
This reverts commitd9c302c.
rosta commentedAug 23, 2019
I rolled back most of the changes. Just left a single correction. FI: I replaced the lineNormalizer in my code to the identity function, and renormalize afterwards. Sorry to take so long with this but I had other things ongoing! |
Correction to reportLinesUnchanged / showInlineDiffs incompatibility
Possible implementation of rawValue option