Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork209
Reformat Apache 2.0 headers (remove #%L things)#28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Collaborator
wumpz commentedOct 29, 2018
After thinking about it. Those %L things are used by Maven license plugin to include and update the LIC text. So what is the reason to remove it? |
ContributorAuthor
koppor commentedOct 29, 2018 via email
Never used the maven license Plugin 😇. In the context of Eclipse Winery,we use IntelliJ's code header functionality or update the headers manually:Each class has the year of the last change.The main reason was consistency to the other classes in the project.I see three options:A) leave as is and update CONTRIBUTING.MDB) Change all headers to maven styleC) Change all headers to a single line SPDX Identifier, which does not holdany year. The copyright holders are contained in the root LICENSE file.Option C makes it easy to maintain, but hard for license scanners. Option Ais IMHO the least WTF, but harder to maintain. Need to check whether themaven plugin can use some other search expression (similar to IntelliJ) sothat option A is also possibleTobias <notifications@github.com> schrieb am Mo., 29. Okt. 2018, 06:50: … After thinking about it. Those %L things are used by Maven license plugin to include and update the LIC text. So what is the reason to remove it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#28 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABTaflxyqv6NKL2UrxZsifMEWVNYv2hAks5uppc3gaJpZM4X-DTB> . |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.