Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix confusing javadoc documentation for reportLinesUnchanged#186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wumpz merged 1 commit intojava-diff-utils:masterfromanomal:gen-docs
Apr 3, 2024

Conversation

anomal
Copy link
Contributor

The original javadoc comments has problems:

  • Typo on "originial"
  • Typo on "reportLinesUnWrappedchanged"
  • Refers to internal code/processing logic over public API
  • Can be interpreted to meanDiffRow.Tags would be absent
  • Does not clearly disambiguate thatreportLinesUnchanged is not a flag to omit the lines withDiffRow.Tag.EQUAL

I spent hours trying to figure out why settingreportLinesUnchanged tofalse still reports the lines that are unchanged. I had to go through the source code to figure out what this method was for.

@anomalanomal changed the titleFix confusing javadoc documentation for reportLinesUnWrappedFix confusing javadoc documentation for reportLinesUnchangedMar 29, 2024
@wumpzwumpz merged commit6279142 intojava-diff-utils:masterApr 3, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@anomal@wumpz
[8]ページ先頭
©2009-2025 Movatter.jp