Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fixes #182 by parsing diffs with 'Binary files'#183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wumpz merged 1 commit intojava-diff-utils:masterfrommachadoit:master
Feb 28, 2024

Conversation

machadoit
Copy link
Contributor

Adds fix for#182 by parsing diff lines that start with 'Binary files'

@machadoit
Copy link
ContributorAuthor

Names liketestParseIssue182_add are getting flagged by Codacy, do change them to your standards, or let me know if you would like to change them. Thanks!

@machadoit
Copy link
ContributorAuthor

In the meanwhile, after some more testing, and checking the fields of fromFile and toFile, there seems there is already a bug ondiff blocks that don't have any changes or something like that?https://github.com/java-diff-utils/java-diff-utils/pull/184/files

This change also suffers from the same bug, and will consume more lines that it should as part of the binary file block

@wumpzwumpz merged commit54324fb intojava-diff-utils:masterFeb 28, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@machadoit@wumpz
[8]ページ先頭
©2009-2025 Movatter.jp