Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork209
Added ability to apply patch to existing list inplace#152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
wumpz merged 3 commits intojava-diff-utils:masterfromandre161292:feature/apply-to-original-collectionSep 1, 2022
Merged
Added ability to apply patch to existing list inplace#152
wumpz merged 3 commits intojava-diff-utils:masterfromandre161292:feature/apply-to-original-collectionSep 1, 2022
+39 −12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Collaborator
wumpz commentedAug 16, 2022
But as I understand it, you did not add but change the existing behaviour, right? |
ContributorAuthor
andre161292 commentedAug 16, 2022
No, i didn't change the existing behavior. I extracted the core functionality to make it accessible from the outside, that's why it looks changed at first. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Motivation
I'm using java-diff-utils to update lists in JPA models from a DTOs. As Hibernate uses proxies and records any removal/add/swap, but has it's problems when using clear/addAll, this is the only option to make patching my lists work.
In older versions i accessed AbstractDelta's
applyTodirectly, but that fell away when it was made hidden in3075742.Changes
I added a the methods
applyToExistingand it's oppositerestoreToExistingtoPatch, to make it possible to update lists in-place and updated JavaDoc accordingly.Minor improvements
I corrected a typo in the method-name
verifyAntApplyTo->verifyAndApplyTo