Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork209
StringUtils.wrapText will not split surrogate pair.#103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
wumpz merged 1 commit intojava-diff-utils:masterfrommikesamuel:string-utils-wrap-surrogatesNov 22, 2020
Merged
StringUtils.wrapText will not split surrogate pair.#103
wumpz merged 1 commit intojava-diff-utils:masterfrommikesamuel:string-utils-wrap-surrogatesNov 22, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Previously, StringUtils.wrapText(".\uD800\uDC00.", 2) // ^ index 2 points herewould insert a `<br/>` between two paired surrogates.Now, it shifts the insertion point to a whole code-point boundary.ContributorAuthor
mikesamuel commentedNov 5, 2020
With this patch, openjdk version "11.0.8" 2020-07-14 The java.lang.Character APIs used are |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
would insert a
<br/>between two paired surrogates.Now, it shifts the insertion point to a whole code-point boundary.