Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jul 4, 2025. It is now read-only.
/cortex.cppPublic archive

Hostfix: remove not needed params from load_model#2209

Merged
qnixsynapse merged 10 commits intodevfromhostfix/remove_pooling
Jun 12, 2025

Conversation

@qnixsynapse
Copy link
Contributor

Describe Your Changes

  • Remove unneeded params from load_model and use llama.cpp defaults for most of the params

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

The --pooling flag was removed as the mean pooling functionality not needed in chat models. This fixes the regression
Adds support for the ctx_len parameter by appending --ctx-size with its value. Removed outdated parameter mappings from the kParamsMap to reflect current implementation details and ensure consistency.
When the model path contains both "jan" and "nano" (case-insensitive), automatically addspeculative decoding parameters to adjust generation behavior. This improvesflexibility by enabling environment-specific configurations without manualparameter tuning. Also includes necessary headers for string manipulation andfixes whitespace in ctx_len handling.
The comment was redundant as the code's purpose is clear without it, improving readability.
qnixsynapseand others added6 commitsJune 12, 2025 12:47
This commit introduces new configuration parameters and their corresponding command-line flags for the local engine. The changes include:- Adding "flash_attn" to ignored parameters- Mapping UI parameters to CLI flags (e.g., cpu_threads → --threads)- Expanding support for various model configuration optionsThese additions enhance the flexibility of the local engine by enabling fine-grained control over performance and behavior through both UI and CLI interfaces.
The condition was updated to include 'qwen' in the check for triggering specific parameters('--temp', '--top-p', etc.), aligning it with the existing 'jan' and 'nano' validation logic. This allowsthe same parameter configuration to apply to 'qwen' models as well as the original keywords.
Removed deprecated parameters such as "dynatemp_exponent" and "ctx_len" handling logic,which were no longer needed. Added "flash_attn" back to the ignored parameters list.Cleaned up the parameter conversion logic by removing conditional blocks forspecific model optimizations that are no longer required.
@qnixsynapseqnixsynapse merged commit3a63826 intodevJun 12, 2025
@qnixsynapseqnixsynapse deleted the hostfix/remove_pooling branchJune 12, 2025 08:17
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@Minh141120Minh141120Awaiting requested review from Minh141120

@david-menloaidavid-menloaiAwaiting requested review from david-menloai

1 more reviewer

@louis-janlouis-janlouis-jan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Status: QA

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qnixsynapse@louis-jan

[8]ページ先頭

©2009-2025 Movatter.jp