This repository was archived by the owner on Jul 4, 2025. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork182
fix bug where for local models, delete only the model passed in, not …#2207
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
qnixsynapse approved these changesJun 14, 2025
louis-jan approved these changesJun 14, 2025
Contributor
louis-jan left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…all local models
Describe Your Changes
InJan, I experienced a bug where I would import a model and all of a sudden, all of my other models were gone. I just did some digging finally and it appears that actually what was happening was that I previously deleted a local model, and that deleted all of my local models (all symbolic links). This should provide expected behavior of DeleteModel
Fixes Issues
Self Checklist