This repository was archived by the owner on Jul 4, 2025. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork182
chore: suppress more warnings on Windows#2173
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
qnixsynapse approved these changesMar 25, 2025
Contributor
qnixsynapse left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
262fb1f intodev 15 of 16 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes several changes aimed at simplifying the codebase and improving exception handling. The most important changes involve standardizing the C++ version used across projects, updating exception handling, and refactoring utility functions.
Standardization of C++ Version:
engine/CMakeLists.txt: Removed conditional checks for C++ features and set the C++ standard to 17 unconditionally.engine/cli/CMakeLists.txt: Removed conditional checks for C++ features and set the C++ standard to 17 unconditionally.Exception Handling Improvements:
engine/database/engines.cc: Removed unused exception variable in multiple catch blocks to clean up the code.[1][2][3][4]engine/utils/huggingface_utils.h: Removed unused exception variable in the catch block to clean up the code.Utility Function Refactoring:
engine/utils/dylib_path_manager.cc: Replaced manual UTF-8 to wide string conversion with a utility functioncortex::wc::Utf8ToWstringfor better code readability and maintainability.[1][2]Fixes Issues
Self Checklist