This repository was archived by the owner on Jul 4, 2025. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork182
fix: docker CI#2051
Merged
Merged
fix: docker CI#2051
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
7b1b493 to0f1eb88Comparehiento09 approved these changesFeb 28, 2025
Contributor
hiento09 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
51f9123 intodev 8 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request focuses on improving the configuration setup for different operating systems and updating file paths for Cortex configuration and log files. The most important changes include conditional setup configurations based on the operating system, and updating file paths in the
docker/entrypoint.shscript.Conditional setup configurations based on OS:
.github/workflows/cortex-cpp-quality-gate.yml: Added conditional checks to run different setup configurations for Linux and non-Linux runners.[1][2][3][4][5]Updating file paths:
.github/workflows/test-cortexso-model-hub.yml: Updated the path for thehuggingFaceTokenin the configuration file to use the new directory structure.docker/entrypoint.sh: Changed the paths for the Cortex configuration file and log files to use the new directory structure.[1][2]Fixes Issues
Self Checklist