Commit62b74b7

authored

fix bug where for local models, delete only the model passed in, not all local models (#2207)

Co-authored-by: Ethan Garber <ethancgarber@gmail.com>Co-authored-by: Akarshan Biswas <akarshan@menlo.ai>

1 parentaab3586 commit62b74b7Copy full SHA for 62b74b7

File tree

-7

lines changed

-7

lines changed

Lines changed: 4 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -500,13 +500,10 @@ cpp::result<void, std::string> ModelService::DeleteModel(`
`500`	`500`	`std::filesystem::remove(yaml_fp);`
`501`	`501`	`CTL_INF("Removed:" << yaml_fp.string());`
`502`	`502`	`}else {`
`503`		`-// Remove yaml files`
`504`		`-for (constauto& entry :`
`505`		`-std::filesystem::directory_iterator(yaml_fp.parent_path())) {`
`506`		`-if (entry.is_regular_file() && (entry.path().extension() ==".yml")) {`
`507`		`-std::filesystem::remove(entry);`
`508`		`-CTL_INF("Removed:" << entry.path().string());`
`509`		`- }`
	`503`	`+// Is a local model - Remove only this model's yaml file`
	`504`	`+if (std::filesystem::exists(yaml_fp)) {`
	`505`	`+std::filesystem::remove(yaml_fp);`
	`506`	`+CTL_INF("Removed:" << yaml_fp.string());`
`510`	`507`	`}`
`511`	`508`	`}`
`512`	`509`

Comments

(0)