- Notifications
You must be signed in to change notification settings - Fork6.7k
Julia-Garcia-Polbach#8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ericksicard pushed a commit to ericksicard/Ironhack-lab-javascript-functions-and-arrays that referenced this pull requestOct 29, 2019
josecarneiro added a commit that referenced this pull requestFeb 3, 2020
Sandra, there was a merge conflict due to the renaming of the test spec file, I resolved it locally.I like the addition of the bonus iterations. I find both a considerably harder than the rest. I added an extra bit of clarification regarding how values of different types should be added up.Do you think we should instruct students to not do them in the normal flow of the lab, and only tackle them at the end? Could we ponder moving them to the end of the lab?Additionally, I split the last iteration and passed the requirement to calculate the products diagonally to an extra iteration,#8.1, since my current cohort found it significantly more complex to solve than horizontally and diagonally. Specs don't include any tests for the diagonal product.I'm merging this the PR into master, but I think that it would be productive to follow up on this Lab and do some additional work on it.Cheers!
x8a added a commit to x8a/lab-javascript-functions-and-arrays that referenced this pull requestMar 30, 2020
x8a added a commit to x8a/lab-javascript-functions-and-arrays that referenced this pull requestMar 30, 2020
…ons-and-arrays* 'master' ofhttps://github.com/x8a/lab-javascript-functions-and-arrays: Added solution for the challenges. Bonusironhack-labs#8 is missing.
JohannaXX added a commit to JohannaXX/lab-javascript-functions-and-arrays that referenced this pull requestMay 3, 2020
fermarinsanchez added a commit to fermarinsanchez/lab-javascript-functions-and-arrays that referenced this pull requestMay 3, 2020
fermarinsanchez added a commit to fermarinsanchez/lab-javascript-functions-and-arrays that referenced this pull requestMay 3, 2020
Pumpelgit added a commit to Pumpelgit/lab-javascript-functions-and-arrays that referenced this pull requestMay 5, 2020
Pumpelgit added a commit to Pumpelgit/lab-javascript-functions-and-arrays that referenced this pull requestMay 5, 2020
andresmg added a commit to andresmg/lab-javascript-functions-and-arrays that referenced this pull requestMay 7, 2020
andresmg added a commit to andresmg/lab-javascript-functions-and-arrays that referenced this pull requestMay 7, 2020
andresmg added a commit to andresmg/lab-javascript-functions-and-arrays that referenced this pull requestMay 7, 2020
andresmg added a commit to andresmg/lab-javascript-functions-and-arrays that referenced this pull requestMay 7, 2020
nubidebs added a commit to nubidebs/lab-javascript-functions-and-arrays that referenced this pull requestJun 8, 2020
nubidebs added a commit to nubidebs/lab-javascript-functions-and-arrays that referenced this pull requestJun 8, 2020
giladt added a commit to giladt/lab-javascript-functions-and-arrays that referenced this pull requestAug 11, 2020
giladt added a commit to giladt/lab-javascript-functions-and-arrays that referenced this pull requestAug 11, 2020
Closed
MartinKaumanns pushed a commit to MartinKaumanns/lab-javascript-functions-and-arrays that referenced this pull requestJan 26, 2022
marcozampini added a commit to marcozampini/lab-javascript-functions-and-arrays that referenced this pull requestFeb 22, 2022
marcozampini added a commit to marcozampini/lab-javascript-functions-and-arrays that referenced this pull requestFeb 22, 2022
AlejandroBorrayo added a commit to AlejandroBorrayo/lab-javascript-functions-and-arrays that referenced this pull requestMar 23, 2022
Closed
droidsam1 added a commit to droidsam1/lab-javascript-functions-and-arrays that referenced this pull requestJun 26, 2022
droidsam1 added a commit to droidsam1/lab-javascript-functions-and-arrays that referenced this pull requestJun 26, 2022
…main, not main, backward...). Add unit testing
kahzitacodes added a commit to kahzitacodes/lab-javascript-functions-and-arrays that referenced this pull requestOct 21, 2022
Henrique-mazzoleni added a commit to Thorl/lab-javascript-functions-and-arrays that referenced this pull requestOct 30, 2022
Henrique-mazzoleni added a commit to Thorl/lab-javascript-functions-and-arrays that referenced this pull requestOct 30, 2022
victorperdiguer added a commit to victorperdiguer/lab-javascript-functions-and-arrays that referenced this pull requestNov 6, 2022
physiodevapp added a commit to physiodevapp/lab-javascript-functions-and-arrays that referenced this pull requestNov 17, 2022
physiodevapp added a commit to physiodevapp/lab-javascript-functions-and-arrays that referenced this pull requestNov 17, 2022
physiodevapp added a commit to physiodevapp/lab-javascript-functions-and-arrays that referenced this pull requestNov 17, 2022
michaelmhtong added a commit to michaelmhtong/lab-javascript-functions-and-arrays that referenced this pull requestDec 10, 2022
binghatch added a commit to binghatch/lab-javascript-functions-and-arrays that referenced this pull requestJan 13, 2023
fraulueneburg-ironhack added a commit to fraulueneburg-ironhack/lab-javascript-functions-and-arrays that referenced this pull requestFeb 12, 2023
fraulueneburg-ironhack added a commit to fraulueneburg-ironhack/lab-javascript-functions-and-arrays that referenced this pull requestFeb 12, 2023
serge-svg added a commit to serge-svg/ironhack-labs-lab-javascript-functions-and-arrays that referenced this pull requestFeb 16, 2023
serge-svg added a commit to serge-svg/ironhack-labs-lab-javascript-functions-and-arrays that referenced this pull requestFeb 16, 2023
Bonus 8 - Iterationironhack-labs#8 done!
pedro-louro pushed a commit to pedro-louro/lab-javascript-functions-and-arrays that referenced this pull requestFeb 25, 2023
gunnar-miklis added a commit to gunnar-miklis/lab-javascript-functions-and-arrays that referenced this pull requestMar 23, 2023
gunnar-miklis added a commit to gunnar-miklis/lab-javascript-functions-and-arrays that referenced this pull requestMar 26, 2023
antuuanyf added a commit to antuuanyf/Day_3_Lab that referenced this pull requestJul 5, 2023
theflanders2 added a commit to theflanders2/lab-javascript-functions-and-arrays that referenced this pull requestOct 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
He vuelto a hacer algunos ejercicios de la primera semana, para repasar conceptos.