- Notifications
You must be signed in to change notification settings - Fork6.7k
WDPT-REMOTE-SEP-2021-Karla-Jaramillo#2577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ronhack-labs#3, Iterationironhack-labs#4, Iterationironhack-labs#5, Iterationironhack-labs#6, Iterationironhack-labs#7, Bonus Iterationironhack-labs#3.1, Bonus Iterationironhack-labs#4.1
tomasyaya left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Congratulations on the dedication you have put into the bonus!
Is impressive !
@karlajaramillo
| } | ||
| words.forEach( word => { | ||
| //check if the length of the word is > the maximum length |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nice comments !
| // check if it the argument is a valid array | ||
| let notValidArray = Array.isArray(numbers); | ||
| if(!notValidArray) { | ||
| throw `Not a valid array`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great catch here, do I think the lab asked you to just return null?
| numbers.forEach(item => { | ||
| // check valid values | ||
| let notValid = typeof item === 'object' || Array.isArray(item); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Very tidy !!
This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request is closed. Thank you. |
…#5, Iteration#6, Iteration#7, Bonus Iteration#3.1, Bonus Iteration#4.1