Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

AMS - Web dev - FEB - FT#1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Charlesvdb wants to merge2 commits intoironhack-labs:masterfromCharlesvdb:master

Conversation

Charlesvdb
Copy link

No description provided.

@MFn-Scarboy
Copy link

MFn-Scarboy commentedFeb 21, 2020•
edited
Loading

  • Technical Requirements (10/10)

  • Creative Code (9/10)

  • Code Quality (9/10)

Iteration#6
The 'break's are unnecessary.
Your 'for' loop only runs once (try to see why).

Overall good, indentation could be cleaner

Edit* was running the code against an un-updated test, corrected feedback.

-- Joel

@stale
Copy link

stalebot commentedMar 22, 2020

This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stalestalebot added the stale labelMar 22, 2020
@stale
Copy link

stalebot commentedMar 24, 2020

This pull request is closed. Thank you.

@stalestalebot closed thisMar 24, 2020
@stale
Copy link

stalebot commentedMar 26, 2020

This pull request is closed. Thank you.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Charlesvdb@MFn-Scarboy
[8]ページ先頭
©2009-2025 Movatter.jp