Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

MIA-Jens Heilemann- JS Basic Algorithms#99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
jkai7 wants to merge1 commit intoironhack-labs:masterfromjkai7:master

Conversation

@jkai7
Copy link

No description provided.

@ianizaguirre
Copy link

Hi here is some feedback....

  1. For "Loops" you were asked to make 3 conditions but you only made one 🙁 ...
  • You wrote:
if(hacker1.length>hacker2.length){console.log("Driver has longer name, it has 7 characters");}
  • It should have been:
if(hacker1.length>hacker2.length){console.log('The Driver has the longest name, it has '+hacker1.length+' characters');}elseif(hacker1.length<hacker2.length){console.log('Yo, navigator got the longest name, it has '+hacker2.length+' characters');}else{console.log('wow, you both got equally long names, '+hacker1.length+' characters');}
  1. You forgot to do the last part which asks about printing certain strings depending on the lexicographic order (AKA alphabetical order).

Aside from that, good job and keep up the good work! 😁

Kind Regards,
Ian Izaguirre | Ironhack TA

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jkai7@ianizaguirre

[8]ページ先頭

©2009-2025 Movatter.jp