[AMS-PT-112020] - Rajmohan B#662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

Rajmohankct2003 wants to merge2 commits intoironhack-labs:masterfromRajmohankct2003:master

Closed

[AMS-PT-112020] - Rajmohan B#662

Rajmohankct2003 wants to merge2 commits intoironhack-labs:masterfromRajmohankct2003:master

Conversation

Copy link

Rajmohankct2003 commentedJan 10, 2020

JavaScript Basic Algorithms - Lab

Rajmohankct2003 added2 commits

January 10, 2020 00:25

Iterations 1,2,3 completed

50abf9e

Bonus 1,2 completed

23c16de

lotofcaffeine reviewed

Jan 11, 2020

View reviewed changes

js/index.js

		let phraseToCheck = "Amor, Roma";
		let num2 = phraseToCheck.length - 1;
		let num1;

Copy link

lotofcaffeineJan 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Well done, Your code is really good. 🚀
The only point that I would consider is to give better names for your variables, just to improve legibility but it is already really awesome.

Copy link

stalebot commentedFeb 10, 2020

This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.