Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

MIA FTWD - Nour Cherif Essoussi - April 2019#384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Nourcs wants to merge2 commits intoironhack-labs:masterfromNourcs:master

Conversation

Nourcs
Copy link

No description provided.

@ta-web-mia
Copy link

Nice job! You did a good job covering weird edge cases too, like palindromes that contain spaces or different capitalizations of letters. One tiny tiny issue I found was that the word count was a little bit off. Right now you're checking for an empty space to separate the string with. However, words that are separated by a line break (new paragraphs in other words) are not going to be separated by a space. In this case, your program is counting 259 words when there are actually 261. If you can find a way to solve this minor issue that would be great, but I wouldn't fixate on it too hard.

You're definitely starting in a good place, I'm super impressed with what you've done. Keep up the good work!

  • Nick

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Nourcs@ta-web-mia

[8]ページ先頭

©2009-2025 Movatter.jp