- Notifications
You must be signed in to change notification settings - Fork5.8k
[FTRMT052023] marySueMeissner-eirikKlebo#2647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Removed duplicated text
Extra Resources added
…with-teststarter-code-with-tests
fix typos in tests
…best-ever/masterupdated tests w/ correct return values for empty arrays
…iteration-41-insructionsUpdate the iteration 4.1 instructions
compare to a fractional number
…use-jasmineUpdate LAB - use Jasmine for testing
Update bonus iteration 3.2 instructions to align it with the preceding content by removing mention of _refactoring_ and _polymorphism_. The iteration in the current state doesn't allow for efficient practice of refactoring. As well, polymorphism is an OOP concept applied to classes and methods, and therefore it is not suitable to have it mentioned here.
…ration-3-2Revise bonus iteration 3.2 - align with preceding materials
TA-Remote left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
- Good work and nice to see that for some iterations you had more than one solution
index.js Outdated
| //Bonus 2 (Don´t know how to remove space in between) | ||
| let phraseToCheck = "taco cat"; | ||
| let phraseToCheckTrimmed = phraseToCheck.trim(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The .trim() removes the white space from start and end, that's why it didn't solve your problem here.
index.js Outdated
| function getWordCount(str) { | ||
| return str.split(" ").filter(function (n) { | ||
| return n != ""; | ||
| }).length; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That function gets the job done, but could you rewrite that using only afor loop? You could use a similar logic in the palindrome
We worked on this assignment together.