Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(content): automatically recalculate offset when header/footer changes#30862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
HappyKnuckles wants to merge2 commits intoionic-team:main
base:main
Choose a base branch
Loading
fromHappyKnuckles:fix/content-auto-offset

Conversation

@HappyKnuckles
Copy link

Issue number:resolves#26981

What is the current behavior?

Currently, ion-content calculates its layout offsets (--offset-top/bottom) only on initialization or window resize.

If a developer dynamically changes the height of a header or footer (e.g., expanding a searchbar, wrapping text) or adds a toolbar conditionally to the DOM (e.g., via *ngIf), the ion-content does not adjust. This results in content being obscured behind the header/footer.

What is the new behavior?

This PR adds a ResizeObserver and MutationObserver to ion-content to automatically handle dynamic layout changes.

ResizeObserver watches sibling and elements and triggers a recalculation of --offset-top and --offset-bottom whenever their dimensions change.

MutationObserver watches the parent element to detect when or elements are added to or removed from the DOM.

Removes the need for developers to manually listen for standard dynamic layout changes.

Does this introduce a breaking change?

  • Yes
  • No

Other information

I have added a new E2E test suite in core/src/components/content/test/auto-offset which covers:

Visual Regression: Ensures no regressions on initial load.
Functional Header: Expands a header dynamically and asserts that content --offset-top update correctly.
Functional Footer: Expands a footer dynamically and asserts that content --offset-bottom update correctly.
Visual Confirmation: Snapshots verify that the content is physically pushed down/up when toolbars expand.

Before:
image

After:
image

…ngesPreviously, ion-content only calculated layout offsets on initialization or window resize. This caused content to be covered or obscured if a header or footer's dimensions changed dynamically (e.g. expanding a searchbar) or if they were added conditionally to the DOM.This implementation adds a ResizeObserver to watch sibling headers/footers for size changes and a MutationObserver to detect when they are added, triggering an automatic recalculation of the --offset-top and --offset-bottom CSS variables.Fixesionic-team#26981
@HappyKnucklesHappyKnuckles requested a review froma team as acode ownerDecember 11, 2025 19:01
@vercel
Copy link

vercelbot commentedDec 11, 2025

@HappyKnuckles is attempting to deploy a commit to theIonic Team onVercel.

A member of the Team first needs toauthorize it.

@github-actionsgithub-actionsbot added the package: core@ionic/core package labelDec 11, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gnbmgnbmAwaiting requested review from gnbmgnbm is a code owner automatically assigned from ionic-team/framework

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

package: core@ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: content does not update offset variables if header and footer dimensions change

1 participant

@HappyKnuckles

[8]ページ先頭

©2009-2025 Movatter.jp