- Notifications
You must be signed in to change notification settings - Fork13.4k
refactor(datetime): remove usage of ion-buttons#30770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:next
Are you sure you want to change the base?
Conversation
vercelbot commentedNov 5, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for GitHub.
|
df13f40 to340c060CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I compared this test locally with what's onnext and saw no differences so this appears to be a Playwright rendering issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I compared this test locally with what's onnext and saw no differences so this appears to be a Playwright rendering issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I compared this test locally with what's onnext and saw no differences so this appears to be a Playwright rendering issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I compared this test locally with what's onnext and saw no differences so this appears to be a Playwright rendering issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This test was renamed tocustom-clear-button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The before behavior for 1 custom button in theionic theme was to align it to the left, however, I think this is more desired since when showing only the clear button by default it aligns center:
<ion-datetimevalue="2020-03-14"show-clear-button="true"></ion-datetime>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This test is new - we were not previously capturing how it looks when passing more than 1 custom button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This test is new - we were not previously capturing how it looks when passing more than 1 custom button. You can compare how this looks to the docs example:https://ionicframework.com/docs/api/datetime#customizing-button-elements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I renamed the existing test for custom buttons (one button passed) and then added 2 more tests showing how it looks when you pass 2 or 3 buttons to make sure the behavior was the same as before.
Uh oh!
There was an error while loading.Please reload this page.
Issue number: N/A
What is the current behavior?
The Datetime component breaks CSP rules due to the following:
ion-buttonswhich usesscopedencapsulation.ionictheme, it imports Phosphor icons as data URIs, which are blocked byconnect-src 'self' blob:.What is the new behavior?
ion-buttons, removing the dependency on a scoped componention-buttonsion-buttonto change its styles based on being inside of anion-datetimePhosphor icons has not been removed because there is a workaround for it and we will remove its usage across all components in future work.
Does this introduce a breaking change?
Other information