Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(themes): add ionic theme tokens#30708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
brandyscarney wants to merge14 commits intoionic-modular
base:ionic-modular
Choose a base branch
Loading
fromFW-6747

Conversation

brandyscarney
Copy link
Member

@brandyscarneybrandyscarney commentedOct 6, 2025
edited
Loading

Issue number: internal


What is the current behavior?

  • Theionic theme tokens are undefined.
  • Thedark palette does not work with theionic theme.
  • Theionic theme uses different colors thanmd andios.
  • The modular theme tokens are not being used by any tests dependent on URL params.

What is the new behavior?

  • Updates the token interface to accept a numeric scale - it is TBD if it will be the way forward but it is needed for theionic theme currently.
  • Updates the base tokens to use the new interface.
  • Adds tokens for theionic theme based on the existing design tokens.
  • Excludes certain keys (enabled,rippleEffect,formHighlight) from the generated CSS variables.
  • Removes the--background and--ion-background-color from the globalionic theme overrides, allowing it to use the dark palette.
  • Removes the different Ionic colors from theionic theme, ensuring all of the themes use the same named (primary, secondary, etc.) colors.
  • Updates the testing script to pull in the tokens based on the theme & palette passed to the URL.
  • Adds a new npm script,build.newTokens, to generate the token files.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview: Basic
Preview: Color
Preview: Typography

Add the URL parameters?ionic:palette=dark or?ionic:theme={ios|md|ionic} to see the palette or theme change and pull in the associated tokens.

Note: most of the theme specific tokens are not applied yet because we haven't updated the components.

@vercelVercel
Copy link

vercelbot commentedOct 6, 2025
edited
Loading

The latest updates on your projects. Learn more aboutVercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
ionic-frameworkReadyReadyPreviewCommentOct 7, 2025 9:42pm

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: core@ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@brandyscarney

[8]ページ先頭

©2009-2025 Movatter.jp