NotificationsYou must be signed in to change notification settings
Fork13.4k
Star52.2k

feat(datetime): inputModeChanged; add enterInputMode/exitInputMode#30677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

vunizhona wants to merge1 commit intoionic-team:main

base:main

Choose a base branch

fromvunizhona:feat/datetime-picker-public-API-to-programmatically-enter-numeric-input-mode-30634

Open

feat(datetime): inputModeChanged; add enterInputMode/exitInputMode#30677

vunizhona wants to merge1 commit intoionic-team:mainfromvunizhona:feat/datetime-picker-public-API-to-programmatically-enter-numeric-input-mode-30634

Conversation

Copy link

Contributor

vunizhona commentedSep 10, 2025

Issue number:resolves#30634

What is the current behavior?

enterInputMode/exitInputMode is not available in the datetime picker
inputMode status updates are not available

What is the new behavior?

New event: inputModeChanged on ion-datetime with payload { active: boolean }.
New methods: enterInputMode(scope?: 'all'|'hour'|'minute', options?: { focus?: boolean }) and exitInputMode().
Restrict to time, date-time, time-date, and only when numeric columns exist; robust detection (class or [numeric-input]).
Re-emit only when applicable; attach/detach listener to avoid duplicates.
Fallback event emission in tests when picker methods aren’t available; deduped via internal state.
Dev-only warnings via Build.isDev.

Does this introduce a breaking change?

fix(datetime,picker): guard/dedupe input mode events

bbd55e9

datetime: restrict enter/exit to time with numeric columns; re‑emit only when present; add robust detection + fallback (tests) with internal dedupe; gate warnings behind Build.isDev.picker: dedupe ionInputModeChange, debounce exit inactive, toggle aria-hidden around focus.tests: assert single active/inactive; no emit on repeated enter; none for unsupported presentations.