- Notifications
You must be signed in to change notification settings - Fork13.4k
feat(react): migrate to new React Output Target with Next.js support#29715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
christian-bromann wants to merge1 commit intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more aboutVercel for Git ↗︎
|
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
What is the current behavior?
We have done a lot of work to update the
@stencil/react-output-targetpackage to use theLit wrapper as well asNext.js support. We are at a point where we would like to test the state of the new output target package with ecosystem projects to validate its functionality.What is the new behavior?
The new output target provides:
@lit/reactwrapper package@stencil/react-output-targetto be a dependencyDoes this introduce a breaking change?
So far I don't see a reason why this could break someones existing code base. That said, more testing is needed to verify this.
Other information
Unfortunately we can't use
@stencil/react-output-targetyet due to the fact that it requires a more modernmoduleResolutionlikenode16orbundler. The current one (node) is meant to be used for for Node.js versions older than v10, which only support CommonJS require. I've create aseparate issue for this.Update: raised a PR#29717 to enable export maps