- Notifications
You must be signed in to change notification settings - Fork13.4k
Comparing changes
Open a pull request
base repository:ionic-team/ionic-framework
Uh oh!
There was an error while loading.Please reload this page.
base:v8.7.6
head repository:ionic-team/ionic-framework
Uh oh!
There was an error while loading.Please reload this page.
compare:v8.7.7
- 10commits
- 65files changed
- 5contributors
Commits on Oct 8, 2025
Commits on Oct 14, 2025
chore(deps): update actions/setup-node action to v6 (#30726)
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [actions/setup-node](https://redirect.github.com/actions/setup-node) |action | major | `v5` -> `v6` |---### Release Notes<details><summary>actions/setup-node (actions/setup-node)</summary>###[`v6`](https://redirect.github.com/actions/setup-node/compare/v5...v6)[CompareSource](https://redirect.github.com/actions/setup-node/compare/v5...v6)</details>---### Configuration📅 **Schedule**: Branch creation - "every weekday before 11am" (UTC),Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR was generated by [Mend Renovate](https://mend.io/renovate/).View the [repository joblog](https://developer.mend.io/github/ionic-team/ionic-framework).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNDMuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE0My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fix(header): prevent flickering during iOS page transitions (#30705)
Issue number:resolves#25326---------<!-- Please do not submit updates to dependencies unless it fixes anissue. --><!-- Please try to limit your pull request to one type (bugfix, feature,etc). Submit multiple pull requests if needed. -->## What is the current behavior?<!-- Please describe the current behavior that you are modifying. -->The header flickers upon page transition when on iOS mode and using acondensed header:**Entering Page Two (P1 → P2):**When navigating to Page Two, which has a collapsing header (intended tobe hidden until scroll), the header briefly flashes into view. Thishappens because the header is initially rendered with full `opacity: 1`before the component's logic can apply `opacity: 0` to hide it, causinga visible flicker.**Navigating Back (P2 → P1):**When navigating back, Page One's header briefly bleeds through the topof Page Two. Although Page Two is on top (`z−index: 100`), itscollapsing header is set to `opacity: 0`. This transparency allows PageOne header (`z−index: 99`) to become visible underneath, as thetransparent area cannot block the content below it.The header flickers upon page transition when on iOS mode and using afade header:**Entering Page Two (P1 → P2):**When navigating to Page Two, which has a fade header (should not have abackground on load), the header background briefly flashes into view.This happens because the header is initially rendered with full`opacity: 1` before the component's logic can apply `opacity: 0` to hideit, causing a visible flicker.## What is the new behavior?<!-- Please describe the behavior or changes that are being added bythis PR. -->- Added a transition-specific class that is applied to the condensedion-header element to override its default transparency.This guarantees the header to act as an opaque block during the pagetransition, eliminating visual flickering caused by early `opacity: 0`or the header underneath bleeding through.- Added a transition-specific class that is applied to the fadeion-header element to override its default opaque background.This guarantees the header to act as a transparent block during the pagetransition, eliminating visual flickering caused by default `opacity:1`.## Does this introduce a breaking change?- [ ] Yes- [x] No<!-- If this introduces a breaking change:1. Describe the impact and migration path for existing applicationsbelow. 2. Update the BREAKING.md file with the breaking change.3. Add "BREAKING CHANGE: [...]" to the commit description when merging.Seehttps://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footerfor more information.-->## Other information<!-- Any other information that is important to this PR such asscreenshots of how the component looks before and after the change. -->Dev build: `8.7.6-dev.11759524961.1cff6814`
Commits on Oct 15, 2025
chore(deps): update github/codeql-action action to v4 (#30717)
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---||[github/codeql-action](https://redirect.github.com/github/codeql-action)| action | major | `v3` -> `v4` |---### Release Notes<details><summary>github/codeql-action (github/codeql-action)</summary>###[`v4`](https://redirect.github.com/github/codeql-action/compare/v3...v4)[CompareSource](https://redirect.github.com/github/codeql-action/compare/v3...v4)</details>---### Configuration📅 **Schedule**: Branch creation - "every weekday before 11am" (UTC),Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR was generated by [Mend Renovate](https://mend.io/renovate/).View the [repository joblog](https://developer.mend.io/github/ionic-team/ionic-framework).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzEuOSIsInVwZGF0ZWRJblZlciI6IjQxLjEzMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fix(select): improve screen reader announcement timing for validation…
… errors (#30723)Issue number: internal---------<!-- Please do not submit updates to dependencies unless it fixes anissue. --><!-- Please try to limit your pull request to one type (bugfix, feature,etc). Submit multiple pull requests if needed. -->## What is the current behavior?<!-- Please describe the current behavior that you are modifying. -->Currently, when an error text is shown, it may not announce itself tovoice assistants. This is because the way error text currently works isby always existing in the DOM, but being hidden when there is no error.When the error state changes, the error text is shown, but as far as thevoice assistant can tell it's always been there and nothing has changed.## What is the new behavior?<!-- Please describe the behavior or changes that are being added bythis PR. -->- Updated aria attributes- Added observer with an observerWe had to do this with a mutation observer and state because it'simportant in some frameworks, like Angular, that state changes to causea re-render. This, combined with some minor aria changes, makes it sothat when a field is declared invalid, it immediately announces theinvalid state instead of waiting for the user to go back to the invalidfield.## Does this introduce a breaking change?- [ ] Yes- [x] No<!-- If this introduces a breaking change:1. Describe the impact and migration path for existing applicationsbelow. 2. Update the BREAKING.md file with the breaking change.3. Add "BREAKING CHANGE: [...]" to the commit description when merging.Seehttps://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footerfor more information.-->## Other information<!-- Any other information that is important to this PR such asscreenshots of how the component looks before and after the change. -->[Preview](https://ionic-framework-git-fw-6797-ionic1.vercel.app/src/components/select/test/validation/)
refactor(button): only check for undefined fill (#30722)
Issue number: internal---------## What is the current behavior?Button checks for undefined and null fill as a result of Stencil bugstenciljs/core#3586## What is the new behavior?- Removes check for `null` with the release of Stencil v4.38.0- No test needed as one exists already:https://github.com/ionic-team/ionic-framework/pull/26339/files## Does this introduce a breaking change?- [ ] Yes- [x] NoCo-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
fix(header): ensure one banner role in condensed header (#30718)
Issue number: internal---------<!-- Please do not submit updates to dependencies unless it fixes anissue. --><!-- Please try to limit your pull request to one type (bugfix, feature,etc). Submit multiple pull requests if needed. -->## What is the current behavior?<!-- Please describe the current behavior that you are modifying. -->As per accessibility guidelines, there should only be one bannerlandmark per page. A condensed header creates two banner landmarks since2 `ion-header` components are required on the page. `ion-header` renderswith a `role="banner"` by default (when not in `ion-menu`).The visual effect of the condensed header is achieved by rendering twodistinct header components. Because both components exist in the code atthe same time and both have `role="banner"`, they create a duplicatelandmark announcement for screen readers. This leads to a violation withthe accessibility guidelines.## What is the new behavior?<!-- Please describe the behavior or changes that are being added bythis PR. -->- The role is updated to either `none` or `banner` based off theheader's active state.- Added test.## Does this introduce a breaking change?- [ ] Yes- [x] No<!-- If this introduces a breaking change:1. Describe the impact and migration path for existing applicationsbelow. 2. Update the BREAKING.md file with the breaking change.3. Add "BREAKING CHANGE: [...]" to the commit description when merging.Seehttps://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footerfor more information.-->## Other information<!-- Any other information that is important to this PR such asscreenshots of how the component looks before and after the change. -->[Preview](https://ionic-framework-git-fw-6767-ionic1.vercel.app/src/components/header/test/condense/?ionic%3Amode=ios)
chore(deps): update playwright (#30709)
> [!NOTE]> Mend has cancelled [the proposedrenaming](https://redirect.github.com/renovatebot/renovate/discussions/37842)of the Renovate GitHub app being renamed to `mend[bot]`.> > This notice will be removed on 2025-10-07.<hr>This PR contains the following updates:| Package | Change | Age | Confidence | Type | Update ||---|---|---|---|---|---|| [@playwright/test](https://playwright.dev)([source](https://redirect.github.com/microsoft/playwright)) |[`^1.55.1` ->`^1.56.0`](https://renovatebot.com/diffs/npm/@playwright%2ftest/1.55.1/1.56.0)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)| devDependencies | minor || mcr.microsoft.com/playwright | `v1.55.1` -> `v1.56.0` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)| final | minor |---### Release Notes<details><summary>microsoft/playwright (@​playwright/test)</summary>###[`v1.56.0`](https://redirect.github.com/microsoft/playwright/compare/v1.55.1...v1.56.0)[CompareSource](https://redirect.github.com/microsoft/playwright/compare/v1.55.1...v1.56.0)</details>---### Configuration📅 **Schedule**: Branch creation - "every weekday before 11am" (UTC),Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.👻 **Immortal**: This PR will be recreated if closed unmerged. Get[confighelp](https://redirect.github.com/renovatebot/renovate/discussions) ifthat's undesired.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR was generated by [Mend Renovate](https://mend.io/renovate/).View the [repository joblog](https://developer.mend.io/github/ionic-team/ionic-framework).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzEuOSIsInVwZGF0ZWRJblZlciI6IjQxLjEzMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff v8.7.6...v8.7.7
Uh oh!
There was an error while loading.Please reload this page.