Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Adds CSS visibily expecation toTealAppDriver that use JS and wait accordingly#1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
averissimo merged 8 commits intobring_testsfromvisibility_feat@bring_tests
Dec 17, 2025

Conversation

@averissimo
Copy link
Contributor

…ediate execution

Pull Request

Implementsexpectation for visibility usingAppDriver$wait_for_js API that is more robust than immediate execution.

@osenanosenan self-assigned thisDec 12, 2025
Copy link
Contributor

@osenanosenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi, the changes look ok. It makes tests more readable. Unfortunately is not working for me locally:

image

If I checkout to branchbring_tests all tests are passed
image

averissimo reacted with eyes emoji
@averissimo
Copy link
ContributorAuthor

averissimo commentedDec 16, 2025•
edited
Loading

@osenan can you test it again?

I triggered theCI manually and all the shinytest2 pass (for both this andbring_tests branches). The linter error is from files that this PR does not change.

image

Copy link
Contributor

@osenanosenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi, after running the last changes locally, it worked!! Good job!

@averissimoaverissimo merged commitda1c72d intobring_testsDec 17, 2025
1 check passed
@averissimoaverissimo deleted the visibility_feat@bring_tests branchDecember 17, 2025 17:55
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 17, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@osenanosenanosenan approved these changes

Assignees

@osenanosenan

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@averissimo@osenan
[8]ページ先頭
©2009-2025 Movatter.jp