- Notifications
You must be signed in to change notification settings - Fork1
feat: add settings components [LW-10713]#47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| export const separator = style({ | ||
| width: '100%', | ||
| height: 1, | ||
| background: vars.colors.$settings_item_separator_color, | ||
| selectors: { | ||
| [`${root}:first-of-type &`]: { | ||
| background: 'none', | ||
| }, | ||
| [`${root}:hover &`]: { | ||
| background: 'none', | ||
| }, | ||
| }, | ||
| }); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggestions: Maybe you can useDividerhttps://github.com/input-output-hk/lace-ui-toolkit/tree/main/src/design-system/divider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yeah good point, i thought that it might be more work to make it react to these selectors then?
| pt="$32" | ||
| pb="$32" | ||
| pl="$16" | ||
| pr="$16" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Q: can we at least allow classname or something to override this ? Maybe it won't be applicable in all the places.
Or, remove a wrapper Box and control it from the parent if necessary?
Separator is an end-app choice.
Just thinking loudly... WDYT?
@tomislavhoracek sorry, i should have added a note to this PR that it's just a draft to save the idea for potentially later.@pczeglik-iohk already decided that this will not be continued/merged in the ui-toolkit |
No worries@DominikGuzei 🙂 |
Uh oh!
There was an error while loading.Please reload this page.
This PR is a proposal to add components for composing a settings section like in Lace: