This repository was archived by the owner on Oct 29, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork524
chore: InfluxDBClient.close should also close udp socket#906
Open
yabberyabber wants to merge1 commit intoinfluxdata:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Currently, InfluxDBClient.close only works for http connections.The function explicitly skips closing the udp_socket member. UDPconnections may not cost the system anything but leaving anysort of socket open can cause certain dynamic analysis tools tocomplain.With this patch we explicitly close the socket which quiets ourlinter's warnings.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, InfluxDBClient.close only works for http connections.
The function explicitly skips closing the udp_socket member. UDP
connections may not cost the system anything but leaving any
sort of socket open can cause certain dynamic analysis tools to
complain.
With this patch we explicitly close the socket which quiets our
linter's warnings.
Contributor checklist