This repository was archived by the owner on Oct 29, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork524
Fixed gzip tests by comparing decompressed values#854
Open
DrakezulsMinimalism wants to merge2 commits intoinfluxdata:masterChoose a base branch fromDrakezulsMinimalism:fix-gzip-test
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Fixed gzip tests by comparing decompressed values#854
DrakezulsMinimalism wants to merge2 commits intoinfluxdata:masterfromDrakezulsMinimalism:fix-gzip-test
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
During#852 and#853 I noticed had failures in the test suite for gzip (even though I anticipated that nothing related had been changed by me).
Turns out that gzip uses metadata during compression, here the timestamp, that is then included in the binary compressed results.
Therefore
I chose option 2 because it avoids the tests to have an impact on the actual implementation of the client, which would have dirty and, in this case, unnecessary.
Contributor checklist
New tests have been added (for feature additions)