Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Fixed gzip tests by comparing decompressed values#854

Open
DrakezulsMinimalism wants to merge2 commits intoinfluxdata:master
base:master
Choose a base branch
Loading
fromDrakezulsMinimalism:fix-gzip-test

Conversation

DrakezulsMinimalism
Copy link

@DrakezulsMinimalismDrakezulsMinimalism commentedOct 9, 2020
edited
Loading

During#852 and#853 I noticed had failures in the test suite for gzip (even though I anticipated that nothing related had been changed by me).

Turns out that gzip uses metadata during compression, here the timestamp, that is then included in the binary compressed results.
Therefore

  1. gzip could be supplied with a static timestamp (possibly also filename, but that did not make a difference for my test runs with one million iterations) to have the same binary output at all times
  2. the test should compare the decompressed result rather than the binary result

I chose option 2 because it avoids the tests to have an impact on the actual implementation of the client, which would have dirty and, in this case, unnecessary.

Contributor checklist
  • Builds are passing
  • New tests have been added (for feature additions)
  • Existing tests have been changed [fixed]

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aviauaviauAwaiting requested review from aviauaviau is a code owner

@sebito91sebito91Awaiting requested review from sebito91

@xginn8xginn8Awaiting requested review from xginn8xginn8 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@DrakezulsMinimalism

[8]ページ先頭

©2009-2025 Movatter.jp