This repository was archived by the owner on Oct 29, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork524
Fix unpacking of negative timestamps from msgpack#846
Open
bitoffdev wants to merge1 commit intoinfluxdata:masterChoose a base branch frombitoffdev:fix-msgpack-timestamp-parse
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
edb02be
tofa1e7e7
CompareI rebased this PR onto master, which fixed the failing code coverage test.@sebito91, would you be able to take a look at this? My apologies for the at-mention, but I haven't been able to get any eyes on this patch. Let me know if there is a better way to request reviews for this project. Thanks! |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
In#734, support was added to this python client for messagepack, but it does not match the serialization from influxdb for negative timestamps, because it interprets the timestamps as unsigned.
Influxdb uses the tinylib/msgp library to serialize timestamps. Here is an extract of how the timestamps are serialized.
This patch updates the python client to correctly use signed second and nanosecond fields.
Contributor checklist
The only failing test is coverage, which is already failing on master. Fixing the existing issue with coverage is out of scope for this pull request.After rebasing onto master, coverage is also passing.Extra Manual Verification
As a sanity check, I also tested the following script against influxdb (via Docker) before and after my changes, and the result was as expected: negative timestamps fail before this patch and work correctly following this patch.