- Notifications
You must be signed in to change notification settings - Fork524
Types matching#741
base:master
Are you sure you want to change the base?
Types matching#741
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -21,3 +21,4 @@ docs/build/ | |||
| .coverage | |||
| cover | |||
| env | |||
| .vscode | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should be in your system's global .gitignore.
It does not make sense to add every single file created by every single editor in existence to every single project's gitignore.
Look atthis article for help on ignoring files with git.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Okey, thanks for link!
Thanks for contributing! Please add a test so that we consider to merge the patch. Also, please make it optional as it could bread existing uses of the library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd like to think about merging these changes with the changes from#779, especially since you're adding aSHOW FIELD KEYS function.
We should split out theSHOW FIELD KEYS to a separate function, but I like the idea of returning the dict with types for each key.
Add function intowrite_points to getfields types of measurement, before downloading, and if field exists, convert to existed type.
This feature is very usefull if you don't care about typing your date, when download and can will avoid error with types mismatch if you try to loadfloat intointeger field.
P.S. As bonus I add VSCode files into gitignore.