This repository was archived by the owner on Oct 29, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork524
Fix performance degradation with line protocol#592
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Assemble line by line in the commitbf232a7 to remove NaN hassignificant performance impact.This change fixes the issue by keeping the NaN fields before stringifythe dataframe, replacing the fields with empty string, and revertingback to use pd.DataFrame.sum() function to yield the lines.Fixes:influxdata#591
Unfortunately v5.1.0 has just been released with the performance regression vs v5.0 as addressed here. @xginn8 Could you please kindly take a look at this PR? |
I'll wait for his input since he has been leading the data frame client but I will take a look if he does not respond. Thanks for contributing and sorry for the wait :) |
xginn8 approved these changesJun 30, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for contributing!
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Assembling line by line in the commitbf232a7 to remove NaN has
significant performance impact.
This change fixes the issue by keeping the NaN fields before stringify
the dataframe, replacing the fields with empty string, and reverting
back to use pd.DataFrame.sum() function to yield the lines.
Fixes:#591