- Notifications
You must be signed in to change notification settings - Fork186
feat: move-setuptools-build-dependency#696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
codecov-commenter commentedMay 27, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install theCodecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@## master #696 +/- ##======================================= Coverage 90.36% 90.36% ======================================= Files 40 40 Lines 3541 3541 ======================================= Hits 3200 3200 Misses 341 341 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Repeated steps to reproduce and resolve error message in home-assistant. (Note I used Sonnh's build in PyPi). It is working for me. Changes all make sense. 🚴 🏁
feb97ee
intomasterUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Close695
Proposed Changes
_ Before the fix

_ After the fix: I think the new error message means we have had solved the dependency issue, check out "home-assistant-core/script/hassfest/requirements.py" line 169. The new error message is for the homeassistant team

_ My steps to reproduce the issue:
CheckoutHome assistant core repo
Run "source venv/bin/activate"
Run "python3 -m script.gen_requirements_all && pip3.13 install -r requirements_all.txt --break-system-package"
Run "python3 -m script.hassfest --integration-path "home-assistant-core/homeassistant/components/influxdb" --requirement"
My steps to fix
Build influxdb-client-python with the latest change -> Upload to PyPiLink. After that, replace the content of "homeassistant/components/influxdb/manifest.json" like this
manifest.json
Run the same steps as when reproducing the issue again
Checklist
pytest tests
completes successfully