Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: move-setuptools-build-dependency#696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96NguyenHoangSon96 commentedMay 27, 2025
edited
Loading

Close695

Proposed Changes

  • Move the "setuptools" package to build dependency to accommodate new check from the homeassistant library

_ Before the fix
Screenshot 2025-06-01 at 09 11 22

_ After the fix: I think the new error message means we have had solved the dependency issue, check out "home-assistant-core/script/hassfest/requirements.py" line 169. The new error message is for the homeassistant team
Screenshot 2025-06-01 at 09 17 20

_ My steps to reproduce the issue:

  • CheckoutHome assistant core repo

  • Run "source venv/bin/activate"

  • Run "python3 -m script.gen_requirements_all && pip3.13 install -r requirements_all.txt --break-system-package"

  • Run "python3 -m script.hassfest --integration-path "home-assistant-core/homeassistant/components/influxdb" --requirement"

  • My steps to fix

  • Build influxdb-client-python with the latest change -> Upload to PyPiLink. After that, replace the content of "homeassistant/components/influxdb/manifest.json" like this
    manifest.json

  • Run the same steps as when reproducing the issue again

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages areconventional
  • SignCLA (if not already signed

@NguyenHoangSon96NguyenHoangSon96 self-assigned thisMay 27, 2025
@NguyenHoangSon96NguyenHoangSon96 changed the titleAdd initial work in progress for new featurefeat: move-setuptools-build-dependencyMay 27, 2025
@codecov-commenter
Copy link

codecov-commenter commentedMay 27, 2025
edited
Loading

⚠️ Please install the'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.36%. Comparing base(4ce3746) to head(48619c4).

❗ Your organization needs to install theCodecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@##           master     #696   +/-   ##=======================================  Coverage   90.36%   90.36%           =======================================  Files          40       40             Lines        3541     3541           =======================================  Hits         3200     3200             Misses        341      341

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NguyenHoangSon96NguyenHoangSon96 linked an issueMay 28, 2025 that may beclosed by this pull request
@NguyenHoangSon96NguyenHoangSon96 marked this pull request as ready for reviewJune 2, 2025 01:43
Copy link
Contributor

@karel-rehorkarel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Repeated steps to reproduce and resolve error message in home-assistant. (Note I used Sonnh's build in PyPi). It is working for me. Changes all make sense. 🚴 🏁

@NguyenHoangSon96NguyenHoangSon96 merged commitfeb97ee intomasterJun 3, 2025
18 checks passed
@NguyenHoangSon96NguyenHoangSon96 deleted the feat/move-setuptools-build-dependency branchJune 3, 2025 13:12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@karel-rehorkarel-rehorkarel-rehor approved these changes

@jansimonbjansimonbAwaiting requested review from jansimonb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package setuptools should not be a runtime dependency
3 participants
@NguyenHoangSon96@codecov-commenter@karel-rehor

[8]ページ先頭

©2009-2025 Movatter.jp