- Notifications
You must be signed in to change notification settings - Fork187
write 2 points in example.py#683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fix: write 2 points in example.py
codecov-commenter commentedDec 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install theCodecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@## master #683 +/- ##==========================================- Coverage 90.28% 90.20% -0.08%========================================== Files 40 40 Lines 3541 3533 -8 ==========================================- Hits 3197 3187 -10- Misses 344 346 +2 ☔ View full report in Codecov by Sentry. |
Closes #
Proposed Changes
Create and write 2 points instead of one in the example.py file.
Previously, the second write (with the line_protocol) erased the first write (with the Point structure) as timestamps are the same. Besides, the WritePrecision.MS made the line_protocol time conversion to somewhere in February 1970 (at time of writing), instead of current date & time.
So it is proposed here to write two distinct points to improve example understanding, and remove the WritePrecision.MS when writing with line_protocol, as is done in other examples, in order to write both points at the timestamp of execution.
Checklist