Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add type checks for Authorization with new example.#682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
karel-rehor merged 2 commits intomasterfromfix/issue680
Dec 4, 2024

Conversation

karel-rehor
Copy link
Contributor

@karel-rehorkarel-rehor commentedDec 3, 2024•
edited
Loading

Closes#680

Proposed Changes

  • Add type checks in constructor of Authorization
    • verifyorg_id is a string
    • verifypermissions is a list
  • Add type check inauthorizations_api.create_authorization that argument passed asauthorization is of typeAuthorization.
  • Addexamples/authorizations.py

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages areconventional
  • SignCLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commentedDec 3, 2024•
edited
Loading

⚠️ Please install the'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.36%. Comparing base(2d0adb9) to head(989fb88).
Report is 2 commits behind head on master.

❗ Your organization needs to install theCodecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@##           master     #682   +/-   ##=======================================  Coverage   90.36%   90.36%           =======================================  Files          40       40             Lines        3539     3541    +2     =======================================+ Hits         3198     3200    +2  Misses        341      341

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@karel-rehorkarel-rehor marked this pull request as ready for reviewDecember 3, 2024 13:59
Copy link
Contributor

@bednarbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Add new example to theexamples/README.md.

@karel-rehorkarel-rehor merged commitab16384 intomasterDec 4, 2024
16 checks passed
@karel-rehorkarel-rehor deleted the fix/issue680 branchDecember 4, 2024 10:19
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bednarbednarbednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot create authorization token via python client
3 participants
@karel-rehor@codecov-commenter@bednar
[8]ページ先頭
©2009-2025 Movatter.jp