Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: catch CancelledError and TimeoutError and add note about timeout#679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
karel-rehor merged 3 commits intomasterfromfix/AsyncCsvErrors
Nov 25, 2024

Conversation

karel-rehor
Copy link
Contributor

@karel-rehorkarel-rehor commentedNov 22, 2024•
edited
Loading

Closes#671

Proposed Changes

influx_csv_parser catchCancelledError andTimeoutError and add a note to check the clienttimeout setting.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages areconventional
  • SignCLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commentedNov 22, 2024•
edited
Loading

⚠️ Please install the'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is0% with5 lines in your changes missing coverage. Please review.

Project coverage is 90.36%. Comparing base(012c50a) to head(36888b0).
Report is 5 commits behind head on master.

Files with missing linesPatch %Lines
influxdb_client/client/flux_csv_parser.py0.00%5 Missing⚠️

❗ Your organization needs to install theCodecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@##           master     #679      +/-   ##==========================================- Coverage   90.49%   90.36%   -0.13%==========================================  Files          40       40                Lines        3534     3539       +5     ==========================================  Hits         3198     3198- Misses        336      341       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@@ -1,6 +1,6 @@
"""Parsing response from InfluxDB to FluxStructures or DataFrame."""


import asyncio
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

sync client doesn't includeasyncio library. You have to check the type by name... maybe something like:

elif'DataFrame'intype(record).__name__:

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Updated to catchBasicException and then check type.import asyncio removed.

@karel-rehorkarel-rehor marked this pull request as ready for reviewNovember 25, 2024 13:07
Copy link
Contributor

@bednarbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 🚀

@karel-rehorkarel-rehor merged commit44dd00e intomasterNov 25, 2024
16 checks passed
@karel-rehorkarel-rehor deleted the fix/AsyncCsvErrors branchNovember 25, 2024 13:49
@bednarbednar added this to the1.48.0 milestoneNov 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bednarbednarbednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.

The error asyncio.exceptions.CancelledError occurred while parsing the CSV.
3 participants
@karel-rehor@codecov-commenter@bednar
[8]ページ先頭
©2009-2025 Movatter.jp