- Notifications
You must be signed in to change notification settings - Fork182
Implement flush in write_api#678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-commenter commentedOct 19, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install theCodecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@## master #678 +/- ##==========================================+ Coverage 90.49% 90.52% +0.03%========================================== Files 40 40 Lines 3534 3535 +1 ==========================================+ Hits 3198 3200 +2+ Misses 336 335 -1 ☔ View full report in Codecov by Sentry. |
bednar left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@minsungoh, thanks for your PR 👍. Please ensure all items in ourChecklist are completed:

minsungoh commentedOct 24, 2024
Sorry for late reply. i have problem in pytest. is there a auto config for test or should i input my own config? then what file should i change? there are config.ini, config.json, config.toml in tests/. |
bednar commentedOct 24, 2024
If you are using Linux or MacOS, you should be able to run tests following this guide -https://github.com/influxdata/influxdb-client-python?tab=readme-ov-file#local-tests |
minsungoh commentedOct 25, 2024
There's only mocking tests in |
Uh oh!
There was an error while loading.Please reload this page.
Proposed Changes
write_api is send data when it close or delete on batching mode. but i want to reuse same object. so i implement flush function as simply call on_complete
Checklist
pytest testscompletes successfully