Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Implement flush in write_api#678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
minsungoh wants to merge3 commits intoinfluxdata:master
base:master
Choose a base branch
Loading
fromminsungoh:master

Conversation

minsungoh
Copy link

@minsungohminsungoh commentedOct 19, 2024
edited
Loading

Proposed Changes

write_api is send data when it close or delete on batching mode. but i want to reuse same object. so i implement flush function as simply call on_complete

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages areconventional
  • SignCLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commentedOct 19, 2024
edited
Loading

⚠️ Please install the'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.52%. Comparing base(012c50a) to head(b322815).

❗ Your organization needs to install theCodecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@##           master     #678      +/-   ##==========================================+ Coverage   90.49%   90.52%   +0.03%==========================================  Files          40       40                Lines        3534     3535       +1     ==========================================+ Hits         3198     3200       +2+ Misses        336      335       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Copy link
Contributor

@bednarbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@minsungoh, thanks for your PR 👍. Please ensure all items in ourChecklist are completed:

image

@minsungoh
Copy link
Author

Sorry for late reply. i have problem in pytest. is there a auto config for test or should i input my own config? then what file should i change? there are config.ini, config.json, config.toml in tests/.

@bednar
Copy link
Contributor

If you are using Linux or MacOS, you should be able to run tests following this guide -https://github.com/influxdata/influxdb-client-python?tab=readme-ov-file#local-tests

minsungoh reacted with thumbs up emoji

@minsungoh
Copy link
Author

There's only mocking tests intests/test_WriteApiBatching.py, so i made a class extends BaseTest for testing flush works. however, is there a better way to verify that record's saved on influxdb instead of sleep?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bednarbednarAwaiting requested review from bednar

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@minsungoh@codecov-commenter@bednar

[8]ページ先頭

©2009-2025 Movatter.jp