Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: linting at flux_table.py#677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bednar merged 4 commits intoinfluxdata:masterfromyouarecode:master
Oct 8, 2024
Merged

Conversation

youarecode
Copy link
Contributor

@youarecodeyouarecode commentedOct 7, 2024•
edited by bednar
Loading

Closes#674

Proposed Changes

classFluxTable(FluxStructure):def__init__(self)->None:self.columns:List[FluxColumn]= []#<<<<---- Added this typingself.records:List[FluxRecord]= []#<<<<---- Added this typing

Testing found the following warnings:

  1. duplicated import
#setup.pyfrompathlibimportPathfrompathlibimportPath#<<<<-------------deleted duplicated

NOTE

There's still unrelated tests that are not passing
make lint

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages areconventional
  • SignCLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commentedOct 7, 2024•
edited
Loading

⚠️ Please install the'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base(3d70dbd) to head(fabc9da).
Report is 8 commits behind head on master.

❗ Your organization needs to install theCodecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@##           master     #677   +/-   ##=======================================  Coverage   90.47%   90.47%           =======================================  Files          40       40             Lines        3528     3528           =======================================  Hits         3192     3192             Misses        336      336
FlagCoverage Δ
?

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Copy link
Contributor

@bednarbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@youarecode thanks for your PR 👍

LGTM 🚀

@bednarbednar merged commit28a4a04 intoinfluxdata:masterOct 8, 2024
15 checks passed
@bednarbednar added this to the1.47.0 milestoneOct 8, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bednarbednarbednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

flux_table.py Linting (Bug and FIX)
3 participants
@youarecode@codecov-commenter@bednar
[8]ページ先頭
©2009-2025 Movatter.jp