fix: url attribute type validation#672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bednar merged 4 commits intoinfluxdata:masterfromVitalyChait:patch-1

Sep 24, 2024

Merged

fix: url attribute type validation#672

bednar merged 4 commits intoinfluxdata:masterfromVitalyChait:patch-1

Sep 24, 2024

Conversation

Copy link

Contributor

VitalyChait commentedSep 17, 2024•
edited
Loading

fix: added type validation to an attribute in client object

Proposed Changes

It is possible to pass "None" by mistake to the InfluxDBClient object.
I propose to do a quick sanity check on it.

Traceback example:
client_obj = InfluxDBClient(url=url, token=token, org=org)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "vitaly.chait/.local/lib/python3.12/site-packages/influxdb_client/client/influxdb_client.py", line 63, in init
super().init(url=url, token=token, debug=debug, timeout=timeout, enable_gzip=enable_gzip, org=org,
File "vitaly.chait/.local/lib/python3.12/site-packages/influxdb_client/client/_base.py", line 56, in init
if self.url.endswith("/"):
^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'endswith'
Exception ignored in: <function InfluxDBClient.del at 0x7ff5627789a0>
Traceback (most recent call last):
File "vitaly.chait/.local/lib/python3.12/site-packages/influxdb_client/client/influxdb_client.py", line 319, in del
if self.api_client:
^^^^^^^^^^^^^^^
AttributeError: 'InfluxDBClient' object has no attribute 'api_client'

Checklist

CHANGELOG.md updated
Rebased/mergeable
A test has been added if appropriate
pytest tests completes successfully
Commit messages areconventional
SignCLA (if not already signed)

VitalyChait added2 commits

September 17, 2024 12:10

fix: url attribute type validation

c195230

docs: Update CHANGELOG.md

626cefc

Copy link

codecov-commenter commentedSep 17, 2024•
edited
Loading

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base(70ce8cb) to head(9da8314).
Report is 9 commits behind head on master.

❗ Your organization needs to install theCodecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@##           master     #672   +/-   ##=======================================  Coverage   90.47%   90.47%           =======================================  Files          40       40             Lines        3526     3528    +2     =======================================+ Hits         3190     3192    +2  Misses        336      336