Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: addheaders field toInfluxDBError and add example of use#665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bednar merged 6 commits intomasterfromfeat/errorHeaders
Aug 21, 2024

Conversation

karel-rehor
Copy link
Contributor

@karel-rehorkarel-rehor commentedAug 14, 2024
edited
Loading

Proposed Changes

  • Also addheaders field toInfluxDBError (headers are already inrest.py classApiException).
  • Add asserts for headers in existing tests
  • Add test ofheaders field
  • Addhttp_error_handling.py example

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages areconventional
  • SignCLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commentedAug 14, 2024
edited
Loading

⚠️ Please install the'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base(45e6607) to head(db7df20).
Report is 9 commits behind head on master.

❗ Your organization needs to install theCodecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@##           master     #665      +/-   ##==========================================+ Coverage   90.43%   90.47%   +0.03%==========================================  Files          40       40                Lines        3524     3526       +2     ==========================================+ Hits         3187     3190       +3+ Misses        337      336       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.


🚨 Try these New Features:

Copy link
Contributor

@bednarbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for your PR 👍

LGTM 🚀

@bednarbednar added this to the1.46.0 milestoneAug 21, 2024
@bednarbednar merged commit7ad9533 intomasterAug 21, 2024
16 checks passed
@bednarbednar deleted the feat/errorHeaders branchAugust 21, 2024 07:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bednarbednarbednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.46.0
Development

Successfully merging this pull request may close these issues.

3 participants
@karel-rehor@codecov-commenter@bednar

[8]ページ先頭

©2009-2025 Movatter.jp